Skip to content

Properly quote paths for GCC warnings files #8523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

Properly quote paths for GCC warnings files #8523

merged 1 commit into from
Mar 30, 2022

Conversation

earlephilhower
Copy link
Collaborator

Fixes issue identified by @jjsuwa-sys3175 in
46190b6#r69649862

Tested by adding a space to my git repo's path:

"/home/earle/Arduino/hardware/esp8266com space/esp8266/tools/xtensa-lx106-elf/bin/xtensa-lx106-elf-g++" -D__ets__ -DICACHE_FLASH -U__STRICT_ANSI__ -D_GNU_SOURCE -DESP8266 "-I/home/earle/Arduino/hardware/esp8266com space/esp8266/tools/sdk/include" "-I/home/earle/Arduino/hardware/esp8266com space/esp8266/tools/sdk/lwip2/include" "-I/home/earle/Arduino/hardware/esp8266com space/esp8266/tools/sdk/libc/xtensa-lx106-elf/include" -I/tmp/arduino_build_295618/core -c "@/home/earle/Arduino/hardware/esp8266com space/esp8266/tools/warnings/none-g++" -Os -g -free -fipa-pta -Werror=return-type -mlongcalls -mtext-section-literals -fno-rtti -falign-functions=4 -std=gnu++17 -MMD -ffunction-sections -fdata-sections -fno-exceptions -DMMU_IRAM_SIZE=0x8000 -DMMU_ICACHE_SIZE=0x8000 -DNONOSDK22x_190703=1 -DF_CPU=80000000L -DLWIP_OPEN_SRC -DTCP_MSS=536 -DLWIP_FEATURES=1 -DLWIP_IPV6=0 -DARDUINO=10816 -DARDUINO_ESP8266_WEMOS_D1MINI -DARDUINO_ARCH_ESP8266 "-DARDUINO_BOARD=\"ESP8266_WEMOS_D1MINI\"" -DFLASHMODE_DIO "-DSTASSID=\"XXXX\"" "-DSTAPSK=\"XXXX\"" "-I/home/earle/Arduino/hardware/esp8266com space/esp8266/cores/esp8266" "-I/home/earle/Arduino/hardware/esp8266com space/esp8266/variants/d1_mini" "/home/earle/Arduino/hardware/esp8266com space/esp8266/cores/esp8266/spiffs/spiffs_check.cpp" -o /tmp/arduino_build_295618/core/spiffs/spiffs_check.cpp.o

@jjsuwa-sys3175
Copy link
Contributor

LGTM, and thanks for QFEing :)

@earlephilhower earlephilhower merged commit 06e3c56 into esp8266:master Mar 30, 2022
@earlephilhower earlephilhower deleted the round2 branch March 30, 2022 04:07
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
@earlephilhower @hasenradball
Properly quote paths for GCC warnings files (esp8266#8523)
666dae2 
Fixes issue identified by @jjsuwa-sys3175 in
esp8266@46190b6#r69649862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@earlephilhower @jjsuwa-sys3175 @d-a-v